update location of docker image in readme to ECR #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snay2
approved these changes
Feb 4, 2022
| @@ -245,18 +245,18 @@ These configurations can be loaded from various sources with a deterministic pre | |||
| ## Defaults | |||
| Defaults for AEMM configuration are sourced throughout code. Examples below: | |||
| * **CLI flags** | |||
| * [server config defaults](https://github.com/aws/amazon-ec2-metadata-mock/blob/master/pkg/config/server.go#L22) | |||
There was a problem hiding this comment.
Just curious, was the trailing whitespace on these various lines removed by an automated process or did you do it by hand?
I double checked that none of these instances are being treated as significant for the formatting, so this change won't cause any issues.
There was a problem hiding this comment.
Yeah, my editor does this for me. Most of the time it's helpful, but for stuff like this it would be easier to either omit totally, or at least put in a separate commit.
There was a problem hiding this comment.
Sounds good. I'll go ahead and merge it like this.
This was referenced Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.