Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add path tags Name and Test #163

Merged
merged 1 commit into from
Feb 7, 2022
Merged

feat: add path tags Name and Test #163

merged 1 commit into from
Feb 7, 2022

Conversation

renanqts
Copy link
Contributor

@renanqts renanqts commented Feb 7, 2022

Issue #158

Description of changes:
Add paths into the metadata

tags/instance/Name: test-instance
tags/instance/Test: test-tag

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Renan Rodrigues <renanqts@gmail.com>
@renanqts renanqts requested a review from a team as a code owner February 7, 2022 08:26
@brycahta brycahta self-assigned this Feb 7, 2022
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean and complete PR 👍

/lgtm

@brycahta
Copy link
Contributor

brycahta commented Feb 7, 2022

@renanqts running e2e tests locally, if it passes I will merge. We no longer need that ReadMe length validator which is the failing job and preventing other jobs from kicking off.

I can follow-up with PR to remove ReadMe length validator script and job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants