Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update marketplaceProductCodes to be list of strings #180

Merged
merged 2 commits into from
Jun 27, 2022
Merged

update marketplaceProductCodes to be list of strings #180

merged 2 commits into from
Jun 27, 2022

Conversation

brycahta
Copy link
Contributor

Issue #, if available: #179

Description of changes:

  • change marketplaceProductCodes from string to []string and formatting logic to align with IMDS

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested a review from a team as a code owner June 23, 2022 17:19
Copy link
Contributor

@pdk27 pdk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment. Otherwise LGTM.

test/e2e/testdata/aemm-config-integ.json Show resolved Hide resolved
Copy link
Contributor

@pdk27 pdk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants