Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taskresources: ensure terminal reason messages are applied in all known failure paths #1631

Closed
yumex93 opened this issue Oct 18, 2018 · 1 comment
Closed

taskresources: ensure terminal reason messages are applied in all known failure paths #1631

yumex93 opened this issue Oct 18, 2018 · 1 comment
Labels
contributions welcome kind/enhancement scope/ECS Agent

Comments

@yumex93
Copy link
Contributor

yumex93 commented Oct 18, 2018

Summary

For task resource cgroup and volume, the terminal reason attributes need to to added to the model and when it has errors, the error message needs to be populated into the terminal reason. So the terminal reason can be communicated to service side and show to customers.

Expected Behavior

As what ASMAuthResource is doing nowadays, there is a terminal reason attribute in the model, and every time when resource logic has errors, this attribute will be populated with the error message. Later on, it will be used as task stop reason and customers are able to see it.

Observed Behavior

So far, cgroup and volume do not have this attribute, so the error message cannot be communicated back to customers.
@adnxn adnxn changed the title Refactor Task Resource Model taskresources: ensure terminal reason messages are applied in all known failure paths Oct 22, 2018
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue Apr 25, 2019
@sparrc
taskresources: set terminal reason msg for all errors
cc00bea 
closes aws#1631
@sparrc sparrc mentioned this issue Apr 25, 2019
Merged
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue Apr 26, 2019
@sparrc
taskresources: set terminal reason msg for all errors
17c8dd7 
closes aws#1631

return a default terminal reason

remove terminalReason code for cgroups based on PR review

Test that volume errors are propogated
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue Apr 29, 2019
@sparrc
taskresources: set terminal reason msg for all errors
136461f 
closes aws#1631

return a default terminal reason

remove terminalReason code for cgroups based on PR review

Test that volume errors are propogated
sparrc added a commit that referenced this issue Apr 29, 2019
@sparrc
taskresources: set terminal reason msg for all errors (#2004)
42b883e 
* taskresources: set terminal reason msg for all errors

closes #1631

return a default terminal reason

remove terminalReason code for cgroups based on PR review

Test that volume errors are propogated

* fix cleanup error test and add string check
fierlion added a commit to fierlion/amazon-ecs-agent that referenced this issue Apr 30, 2019
@fierlion
add overflow field for int64
799142b 
Updating to go 1.12

Make CGroups CPU period configurable

Signed-off-by: Mohamad Arab <boynux@gmail.com>

taskresources: set terminal reason msg for all errors (aws#2004)

* taskresources: set terminal reason msg for all errors

closes aws#1631

return a default terminal reason

remove terminalReason code for cgroups based on PR review

Test that volume errors are propogated

* fix cleanup error test and add string check

Fix telemetry test for ws2019

On WS2019 functional test image mcr.microsoft.com/windows/servercore:ltsc2019,
the behavior to handle path changed from ws2016 image, it needs to set entrypoint with
absolute path or have entrypoint set to powershell to run executable without absolute path.
Also removed unused binary in windows telemetry test.

add storageReadBytes storageWriteBytes stats
fierlion pushed a commit to fierlion/amazon-ecs-agent that referenced this issue Apr 30, 2019
@sparrc @fierlion
taskresources: set terminal reason msg for all errors (aws#2004)
ef268a7 
* taskresources: set terminal reason msg for all errors

closes aws#1631

return a default terminal reason

remove terminalReason code for cgroups based on PR review

Test that volume errors are propogated

* fix cleanup error test and add string check
@sparrc
Copy link
Contributor

sparrc commented May 8, 2019

closed by #2004

@sparrc sparrc closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions welcome kind/enhancement scope/ECS Agent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adnxn @sparrc @yumex93