Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a task definition to reference auth/credentials #28

Closed
euank opened this issue Mar 5, 2015 · 5 comments
Closed

Allow a task definition to reference auth/credentials #28

euank opened this issue Mar 5, 2015 · 5 comments

Comments

@euank
Copy link
Contributor

euank commented Mar 5, 2015

As suggested by @asans (#4 (comment) on issue 4, option 2)

Right now Docker auth can be configured at the container-instance level and affects all tasks launched on that instance.

It would make sense for auth information to be referenced along with the image it pertains to as part of a task definition. For security and ease of update, it would also make sense if this information could be given as an S3 resource reference.

@asans
Copy link

asans commented Mar 5, 2015

I think the new implementation is a great start. I would also mention that task-level auth info can be viewed as an override of agent-level auth. So if one is set in the task definition, agent will use the auth provided. If not, then it will use one of the global auth credentials.

If this is done, I believe it may capture a large portion of the use cases for private registry access.

@chenliu0831
Copy link

+1 on this so we don't need to bake credentials into the instances... Any progress?

@miahorg
Copy link

miahorg commented Nov 7, 2015

http://docs.aws.amazon.com/AmazonECS/latest/developerguide/private-auth.html

Just ran into this tonight. The docs make it seem like authentication is supported. However our attempts at putting the config.json on the disk to allow ecs-agent to access our private docker hub were not fruitful.

@madeleineth
Copy link

I wrote a walkthrough of how I did it: https://mdln.net/articles/ecs-walkthrough.html

@aaithal
Copy link
Contributor

aaithal commented Jan 26, 2018

The [Task Execution Role]
(https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_execution_IAM_role.html) feature was released for this, back in November 2017. Closing for now. Please let us know if you have any follow up questions/comments.

@aaithal aaithal closed this as completed Jan 26, 2018
danehlim pushed a commit to danehlim/amazon-ecs-agent that referenced this issue Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants