Functional testing #161
Merged
Functional testing #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A pragmatic 👍 I do think there's probably something better in regards to the dependencies and originally I envisioned this as something more distinctly isolated, but it's much more valuable to get this merged than to block on discussing that. I wouldn't mind a squash of my WIP commit, but if you'd rather leave it that's fine too. |
Also properly call them functional tests in the readme
Also some improvements to util / directory structure.
samuelkarp
force-pushed
the
FunctionalTesting
branch
from
f910fba
to
634edcb
Compare
This was referenced Aug 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@euank, I've taken your FunctionalTesting branch and modified it a bit. Specifically, I've moved the tests into the
agent/folder (so we can continue to use godep for dependency management of the tests as well), tagged them with//+build functional(so they get excluded when we do normal builds), updated the imports, and added a Makefile target. I've tested this all against an Agent built from my RetryHandler branch and they pass.(Note: I'm happy to talk about different approaches for organization if you're unhappy with the tests living inside
agent/, but this was the seemingly cleanest approach to me that continues to allow us to handle dependencies properly.)r? @euank @aaithal @sentientmonkey