Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'dev' branch into 'container-ordering' branch #1853

Merged

Conversation

ubhattacharjya
Copy link
Contributor

@ubhattacharjya ubhattacharjya commented Feb 14, 2019

Summary

Merge 'dev' branch into 'container-ordering' branch

Implementation details

Testing

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ubhattacharjya ubhattacharjya requested a review from a team February 14, 2019 22:00
This will  redirect request like //v2/credential to /v2/credential for the correct handler to handle it
@adnxn
Copy link
Contributor

adnxn commented Feb 14, 2019

whatever tests are failing here, before running again - can we track them in issues? either create new ones or reference in existing issues please.

the flakey unit tests are spooky.

@aaithal
Copy link
Member

aaithal commented Feb 14, 2019

Can we please not approve PRs where tests are failing? Repeatedly merging branches with failing tests devalues the existence/execution of tests altogether.

@ubhattacharjya ubhattacharjya changed the title Merge branch Merge dev into container-ordering Feb 15, 2019
@ubhattacharjya ubhattacharjya changed the title Merge dev into container-ordering Merge 'dev' branch into 'container-ordering' branch Feb 15, 2019
@ubhattacharjya ubhattacharjya merged commit 2cf4734 into aws:container-ordering-feature Feb 16, 2019
@ubhattacharjya ubhattacharjya deleted the mergeBranch branch April 8, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet