Merge appmesh to dev branch #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add proxy config into acs model 2. Convert acs model to app mesh config in task 3. Pass app mesh config from task to app mesh plugin and invoke add, del command on network setup and clean
1. Add dockerfile to build amazon-vpc-cni-plugins 2. Add build target in makefile for amazon-vpc-cni-plugins
If user didn't input task metadata endpoint ip of agent or instance metadata endpoint ip in appmesh enabled task, agent should add these two default IPs into appmesh egressIgnoredIPs field as we don't want them to be redirect to envoy proxy
|
Which linux x86 test is failing? |
I think i found a new flaky test #1899 . It failed intermittently, and if you look closer. It failed on 1 out of 3 commits. I will re-trigger the test once i have the vpc plugin updated to re-confirm that it is indeed a flaky test |
petderek
approved these changes
Feb 28, 2019
ubhattacharjya
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge appmesh to dev branch. Enable agent able to pass proxy config to invoke aws-appmesh plugin.
Implementation details
Testing
New tests cover the changes: yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.