NonECSImageOldEnough removal #2251
Conversation
agent/config/config.go
Outdated
| @@ -520,6 +524,7 @@ func environmentConfig() (Config, error) { | |||
| TaskIAMRoleEnabledForNetworkHost: utils.ParseBool(os.Getenv("ECS_ENABLE_TASK_IAM_ROLE_NETWORK_HOST"), false), | |||
| ImageCleanupDisabled: utils.ParseBool(os.Getenv("ECS_DISABLE_IMAGE_CLEANUP"), false), | |||
| MinimumImageDeletionAge: parseEnvVariableDuration("ECS_IMAGE_MINIMUM_CLEANUP_AGE"), | |||
| NonECSMinimumImageDeletionAge: parseEnvVariableDuration("NON_ECS_IMAGE_MINIMUM_CLEANUP_WAIT_DURATION_SINCE_CREATED"), | |||
There was a problem hiding this comment.
Can we just name it as NON_ECS_IMAGE_MINIMUM_CLEANUP_AGE since it serves the same purpose of ECS_IMAGE_MINIMUM_CLEANUP_AGE? And for more implementation details, we just keep it in README and code comments.
agent/config/config.go
Outdated
| @@ -520,6 +524,7 @@ func environmentConfig() (Config, error) { | |||
| TaskIAMRoleEnabledForNetworkHost: utils.ParseBool(os.Getenv("ECS_ENABLE_TASK_IAM_ROLE_NETWORK_HOST"), false), | |||
| ImageCleanupDisabled: utils.ParseBool(os.Getenv("ECS_DISABLE_IMAGE_CLEANUP"), false), | |||
| MinimumImageDeletionAge: parseEnvVariableDuration("ECS_IMAGE_MINIMUM_CLEANUP_AGE"), | |||
| NonECSMinimumImageDeletionAge: parseEnvVariableDuration("NON_ECS_IMAGE_MINIMUM_CLEANUP_WAIT_DURATION_SINCE_CREATED"), | |||
There was a problem hiding this comment.
how about NON_ECS_IMAGE_CLEANUP_MINIMUM_CREATION_AGE . I suggest we add some context to the env var name about how we are using creation time for cleanup logic
|
Since we also need to update README, and this is just a small feature, let's keep README change in the same PR so easier for people to trace back. |
Yeah, will add it to this commit. |
…_ECS_IMAGE_MINIMUM_CLEANUP_AGE (the wait duration between current time and image creation time)
Summary
ECS Agent respects the NON_ECS_IMAGE_MINIMUM_CLEANUP_AGE setting for Non ECS Tracked Images removal.
Currently, customer cannot set the certain age when the nonECS images are deleted. And non ecs images are deleted periodically.
This enhancement gives the customer an option to set NON_ECS_IMAGE_MINIMUM_CLEANUP_AGE env to let customers cleanup the NonECS Images which is older than the certain age (the wait duration between current time and image creation time) .
The other nonECS images will remain undeleted until they are old enough to be deleted since the image is created.
This is related to the github issue #2087
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.