Fix flakey leak test for ACS Handler #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinyic
reviewed
Jun 2, 2022
aws-gibbskt
force-pushed
the
dev
branch
2 times, most recently
from
373dbf0
to
8551ce3
Compare
The multi-channel multi-goroutine implementation of heartbeatHandling created a scenario where goroutines would be routinely leaked in the test which was testing for it. The reality of handling Heartbeat messages is that there was not a need to do multi-thread synchronization with channels at all.
sparrc
approved these changes
Mar 7, 2023
chienhanlin
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The multi-channel multi-goroutine implementation of heartbeatHandling
created a scenario where goroutines would be routinely leaked in the
test which was testing for it.
The reality of handling Heartbeat messages is that there was not a
need to do multi-thread synchronization with channels at all.
Implementation details
The heartbeat handler is now a simple function that dispatches tasks using goroutines and returns.
Testing
Running the once brittle test 100 times (5 runs) after this change had a success rate of 5/5
go test -count=100 -p 1 -v -cover -race -tags unit -coverprofile cover.out -run TestHandlerDoesntLeakGoroutines ./agent/...Running the test only 100 times (5 runs) before the change had a success rate of: 0/5
go test -count=100 -p 1 v -cover -race -tags unit -coverprofile cover.out -run TestHandlerDoesntLeakGoroutines ./agent/...Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.