test: use T.TempDir to create temporary test directory
#3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces `os.MkdirTemp` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `os.MkdirTemp`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
singholt
approved these changes
Feb 7, 2023
yinyic
approved these changes
Feb 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is a cherry-pick of commit from #3159, and I've added a commit to fix windows integ test build.
From the original PR:
This commit replaces
os.MkdirTempwitht.TempDirin tests. The directory created byt.TempDiris automatically removed when the test and all its subtests complete.Prior to this commit, temporary directory created using
os.MkdirTempneeds to be removed manually by callingos.RemoveAll, which is omitted in some tests. The error handling boilerplate e.g.is also tedious, but
t.TempDirhandles this for us nicely.Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun engzerjun@gmail.com
closes #3159
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.