ECS Agent dynamic host port assignment #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add GetHostPort() and update unit tests aws#3570 2. Upudate dockerPortMap() in task.go with dynamic host port range support part 1 aws#3584 3. Upudate dockerPortMap() in task.go with dynamic host port range support part 2 aws#3589 4. Validate the host port/host port range found by ECS Agent before returning it aws#3589 5. Refactor buildPortMapWithSCIngressConfig() in task.go aws#3600
singholt
approved these changes
Mar 6, 2023
singholt
reviewed
Mar 6, 2023
Realmonia
approved these changes
Mar 6, 2023
YashdalfTheGray
approved these changes
Mar 6, 2023
SreeeS
approved these changes
Mar 6, 2023
Closed
Merged
chienhanlin
added a commit
to chienhanlin/amazon-ecs-agent
that referenced
this pull request
Mar 15, 2023
ECS_DYNAMIC_HOST_PORT_RANGE supports both container port range and singular container ports use cases, starting from ECS Agent version 1.70.0. Details of this change are available in aws#3601.
chienhanlin
added a commit
to chienhanlin/amazon-ecs-agent
that referenced
this pull request
Mar 15, 2023
ECS_DYNAMIC_HOST_PORT_RANGE supports both container port range and singular container ports use cases, starting from ECS Agent version 1.70.0. Details of this change are available in aws#3601.
chienhanlin
added a commit
that referenced
this pull request
Mar 16, 2023
ECS_DYNAMIC_HOST_PORT_RANGE supports both container port range and singular container ports use cases, starting from ECS Agent version 1.70.0. Details of this change are available in #3601.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to merge the feature branch feature/dynamicHostPortAssignment into the dev branch.
Following changes, listing from the oldest to the latest, will be introduced to the dev branch after this PR is merged:
Implementation details
Please find details in previous PRs listed in the "Summary" section.
Testing
Please find details in previous PRs listed in the "Summary" section.
New tests cover the changes: yes
Description for the changelog
[Enhancement] Support dynamic host port range assignment for singular ports. The dynamic host port range can be configured with
ECS_DYNAMIC_HOST_PORT_RANGEin ecs.config; if there is no user-specifiedECS_DYNAMIC_HOST_PORT_RANGE, ECS Agent will assign host ports within the default port range, based on platform and Docker API version, for containers that do not have user-specified host ports in task definitions.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.