Add make targets for ecs-agent module and integrate it with CI #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
changed the title
amogh09
changed the title
danehlim
reviewed
Apr 21, 2023
amogh09
force-pushed
the
ecs-agent-mod-start
branch
from
c8a68b0
to
1c0470d
Compare
danehlim
reviewed
Apr 21, 2023
danehlim
previously approved these changes
Apr 21, 2023
amogh09
force-pushed
the
ecs-agent-mod-start
branch
from
f17d515
to
2878b2b
Compare
danehlim
previously approved these changes
Apr 21, 2023
amogh09
changed the title
amogh09
changed the title
danehlim
reviewed
Apr 21, 2023
There was a problem hiding this comment.
Thanks for making these changes!
Not blocking to this PR, but I think we'll want to revisit outstanding make targets that contain ./agent/... and see if we want to include ./ecs-agent/... as well (e.g., make benchmark-test). Let's make sure we're tracking this somewhere internally.
danehlim
approved these changes
Apr 21, 2023
|
Thanks! Yeah I think we would want to look at the other targets on a case-by-case basis and update the ones we think are applicable to ecs-agent module. |
singholt
approved these changes
Apr 24, 2023
Merged
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 16, 2023
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update make targets to include ecs-agent module. Integrate ecs-agent module with CI.
Implementation details
make testnow runs tests for ecs-agent too, and outputs coverage data tocoverprofile-ecs-agent.outfile.make analyze-cover-profilenow analyzes test coverage for ecs-agent module too.make cleannow cleans up coverage data file for ecs-agent tests too.make static-checknow runs static checks for ecs-agent module too.scripts/analyze-cover-profile-init˙ is a duplicate ofscripts/analyze-cover-profile`. Removed the former and updated the latter to take test coverage file as input. Updated static check CI workflow to pass the coverage file to the script.Testing
Checked CI workflow logs that tests are run for ecs-agent module. Also checked that static-check is run for ecs-agent module in the CI workflow logs.
New tests cover the changes: yes
Description for the changelog
Integrate ecs-agent module with CI. Add make targets for ecs-agent module.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.