Require an HTTP Handler instead of a mux Router in TMDS Config #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
changed the title
amogh09
force-pushed
the
router-to-handler
branch
from
dbb695b
to
7aff351
Compare
danehlim
approved these changes
May 1, 2023
prateekchaudhry
approved these changes
May 1, 2023
| @@ -45,7 +45,7 @@ type Config struct { | |||
| writeTimeout time.Duration // http server write timeout | |||
| steadyStateRate float64 // steady request rate limit | |||
| burstRate int // burst request rate limit | |||
| router *mux.Router // router with routes configured | |||
| handler http.Handler // HTTP handler with routes configured | |||
There was a problem hiding this comment.
clarification: is changing from pointer (*mux.Router) to non pointer http.Handler intentional?
There was a problem hiding this comment.
Yeah because http.Handler is an interface whereas mux.Router is a struct.
Merged
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 16, 2023
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TMDS initialization function in
ecs-agentmodule currently requires aRouterinstance from gorilla/mux library to be passed. Usage ofRouterhere is unnecessarily strict and limits the reusability of TMDS to consumers who are using routers from gorilla/mux library. Updating the function to require anhttp.Handlerinstance instead which would allow greater reuse.Routerimplementshttp.Handlerinterface.Implementation details
router *mux.Routerfield in TMDS initialization config tohandler http.Handler.Testing
New tests cover the changes: yes
Description for the changelog
Require an HTTP Handler instead of a mux Router in TMDS Config to increase the reusability of TMDS.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.