Update tools.go documentation + remove agent/acs/model #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
approved these changes
May 3, 2023
mye956
approved these changes
May 3, 2023
SreeeS
approved these changes
May 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is a follow up to #3659.
Add some comments in tools.go files' code to provide more context on their usage (motivation: #3659 (comment)).
Remove unused
agent/acs/modeldirectory and all of its files. Despite this step being included in the PR description of #3659, this step was missed in the actual changes (i.e., only some files inagent/acs/modelwere deleted).Implementation details
agent/tools.goandecs-agent/tools.goagent/acs/modeldirectory and all of its filesTesting
PR tests (unit, integration, and functional).
New tests cover the changes: N/A
Description for the changelog
Update tools.go documentation + remove agent/acs/model
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.