Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.73.0 #3759

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Release 1.73.0 #3759

merged 1 commit into from
Jun 22, 2023

Conversation

prateekchaudhry
Copy link
Contributor

@prateekchaudhry prateekchaudhry commented Jun 22, 2023

Summary

  • Feature - Task Resource Accounting - Adds host resource manager in docker task engine which keeps account of host resources for tasks started on the host. Removes task serialization and uses host resource manager to start tasks on the host as soon as resources become available for a task. #3684 #3706 #3700 #3723 #3741 #3747 #3750
  • Enhancement - Update containernetworking/cni dependency to v1.1.2 and the vpc-cni plugin version #3702
  • Code Quality Improvement - Refactor ACS attach task ENI message handling #3744
  • Code Quality Improvement - Add "more than one ECS failure" case to Task Protection TMDS tests #3749
  • Code Quality Improvement - Move eventstream to /ecs-agent and remove /agent/wsclient #3746
  • Code Quality Improvement - Move TCS Client to ecs-agent module, and switch to use wsclient in ecs-agent module #3726
  • Code Quality Improvement - Add tests for GetTaskProtection API and UpdateTaskProtection API to high-level TMDS tests 3739 #3740
  • Code Quality Improvement - Refactor ACS heartbeat message handling #3724
  • Code Quality Improvement - Move v4 task metadata handler to ecs-agent module with a more generic implementation #3733
  • Fix - Make task not found error message for task protection endpoint consistent with Fargate #3748

Implementation details

Testing

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@prateekchaudhry prateekchaudhry requested a review from a team as a code owner June 22, 2023 18:15
@prateekchaudhry prateekchaudhry added this to the 1.73.0 milestone Jun 22, 2023
danehlim
danehlim previously approved these changes Jun 22, 2023
CHANGELOG.md Outdated
@@ -1,4 +1,16 @@
# Changelog
## 1.73.0
* Enhancement - Task Resource Accounting - Remove task serialization and use host resource manager for starting tasks [#3684](https://github.com/aws/amazon-ecs-agent/pull/3684) [#3706](https://github.com/aws/amazon-ecs-agent/pull/3706) [#3700](https://github.com/aws/amazon-ecs-agent/pull/3700) [#3723](https://github.com/aws/amazon-ecs-agent/pull/3723) [#3741](https://github.com/aws/amazon-ecs-agent/pull/3741) [#3747](https://github.com/aws/amazon-ecs-agent/pull/3747) [#3750](https://github.com/aws/amazon-ecs-agent/pull/3750)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Remove task serialization and use host resource manager for starting tasks does not sound to me covers the full feature, sorry if I am misunderstanding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me update it

Realmonia
Realmonia previously approved these changes Jun 22, 2023
Realmonia
Realmonia previously approved these changes Jun 22, 2023
Copy link
Contributor

@Realmonia Realmonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@prateekchaudhry prateekchaudhry merged commit 929f3ee into aws:dev Jun 22, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants