Windows ebs watcher #3877
Closed
Windows ebs watcher #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhc123
force-pushed
the
windows_ebsWatcher
branch
2 times, most recently
from
9064175
to
c36dc07
Compare
saurabhc123
force-pushed
the
windows_ebsWatcher
branch
from
c36dc07
to
4d67578
Compare
|
Ignore this PR. |
|
Changes already merged in #3866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the feature to detect an attached EBS volume for a EC2 Windows host.
Implementation details
We used the
ebsnvme-id.exewindows utility to detect the volume based on the volumeID.Testing
Four additional unit tests were added on how the
ebsnvme-id.execommand output is handled by new code.New tests cover the changes: yes
Description for the changelog
Added the ability to detect EBS volumes on Windows.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.