Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for gMSA s3 test #3886

Merged
merged 6 commits into from Sep 25, 2023
Merged

Fix for gMSA s3 test #3886

merged 6 commits into from Sep 25, 2023

Conversation

as14692
Copy link
Contributor

@as14692 as14692 commented Sep 5, 2023

Summary

gMSA Linux fetches task's credentialspec from an S3 location. The S3Client session was previously created with the instance's region assuming the instance and S3 region would be the same. This resulted in failure of GMSA functional Linux test in few regions. This change modifies NewS3Client to create S3Client session with S3 bucket region. This will allow functional GMSA Linux test to run in all regions, without creating region specific test buckets and objects.

Implementation details

  • Updated NewS3Client

  • Updated mocks

  • Updated unit tests

Testing

  • Unit tests are modified
  • Manually verified by creating a gMSA task and verifying the S3 bucket region
  • Ran functional test in multiple regions (us-east-1, us-west-1)

Description for the changelog

  • Add fix for the failing functional gMSA S3 test.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@as14692 as14692 marked this pull request as ready for review September 7, 2023 19:46
@as14692 as14692 requested a review from a team as a code owner September 7, 2023 19:46
@singholt
Copy link
Contributor

Thanks for making this change! This not only helps our functional tests but also has customer facing value where their ECS container instance and credential spec s3 object are not in the same region. 🎉

singholt
singholt previously approved these changes Sep 21, 2023
@singholt singholt merged commit 78703a3 into aws:dev Sep 25, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants