Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tcs api modification #3893

Merged
merged 2 commits into from Sep 11, 2023
Merged

Conversation

RichaGangwar
Copy link
Contributor

Summary

This PR updates one of the fields: BytesUtilized in EphemeralStorageMetrics struct in TACS model api.

Implementation details

  1. Updates the api-2.json which is generated from updated TACS model.
  2. "make gogenerate" updates the api.go for TACS.

Testing

Tested using make test.

New tests cover the changes: No

Description for the changelog

Update field name in TACS model api.go

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RichaGangwar RichaGangwar marked this pull request as ready for review September 8, 2023 16:32
@RichaGangwar RichaGangwar requested a review from a team as a code owner September 8, 2023 16:32
@xxx0624
Copy link
Contributor

xxx0624 commented Sep 8, 2023

Should we wait for the change in TACS to be ready first?

@RichaGangwar
Copy link
Contributor Author

Should we wait for the change in TACS to be ready first?

No, we can merge this one. We can wait on the other PR where we consume this.

@RichaGangwar RichaGangwar merged commit 7b69262 into aws:dev Sep 11, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants