Add NodeStageVolume to common CSI client lib #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fierlion
force-pushed
the
fierlion/CSINodeStageClient
branch
from
dd40a8f
to
b73cac6
Compare
fierlion
changed the title
fierlion
force-pushed
the
fierlion/CSINodeStageClient
branch
3 times, most recently
from
edadf33
to
d768083
Compare
fierlion
force-pushed
the
fierlion/CSINodeStageClient
branch
from
d768083
to
db29121
Compare
Merged
Realmonia
previously approved these changes
Sep 15, 2023
danehlim
reviewed
Sep 18, 2023
danehlim
reviewed
Sep 18, 2023
danehlim
reviewed
Sep 18, 2023
| golang.org/x/tools v0.6.0 | ||
| github.com/stretchr/testify v1.8.2 | ||
| golang.org/x/net v0.13.0 | ||
| golang.org/x/sys v0.10.0 |
There was a problem hiding this comment.
Do we care if these versions here (i.e., golang.org/x/sys, golang.org/x/tools) mismatch with the ones used in agent module? I wonder if it would be best practice/beneficial to use the same versions of these between both agent and ecs-agent modules.
There was a problem hiding this comment.
I'll have a follow-up tiny pr to fixup a couple of go module issues -- will add this as well. Good comment.
fierlion
force-pushed
the
fierlion/CSINodeStageClient
branch
from
db29121
to
49a54d7
Compare
xxx0624
reviewed
Sep 19, 2023
fierlion
force-pushed
the
fierlion/CSINodeStageClient
branch
2 times, most recently
from
7cb882b
to
b6d2aac
Compare
fierlion
force-pushed
the
fierlion/CSINodeStageClient
branch
from
b6d2aac
to
4b8742e
Compare
mye956
reviewed
Sep 19, 2023
mye956
reviewed
Sep 19, 2023
xxx0624
approved these changes
Sep 19, 2023
mye956
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Adds the
NodeStageVolumefunction to the csiclient library and extracts the connection setup into a helper function.Implementation details
The client code is modeled after Kubernetes' CSI Client.
Testing
Tested via fierlion/NodeStageAltogether which includes the present CSI Client changes and CSI Driver updates from #3900 as well as hard-coded volume parameters in the task.go
New tests cover the changes: no
Description for the changelog
Add NodeStageVolume to common CSI client library.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.