Add CSI NodeStage #3918
Merged
Add CSI NodeStage #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fierlion
force-pushed
the
fierlion/nodeStageDaemon
branch
from
fcecb22
to
40e2245
Compare
fierlion
force-pushed
the
fierlion/nodeStageDaemon
branch
from
40e2245
to
4d083bd
Compare
xxx0624
approved these changes
Sep 22, 2023
| } | ||
| } | ||
|
|
||
| func (d *nodeService) NodeGetVolumeStats(ctx context.Context, req *csi.NodeGetVolumeStatsRequest) (*csi.NodeGetVolumeStatsResponse, error) { | ||
| klog.V(4).InfoS("NodeGetVolumeStats: called", "args", *req) | ||
| klog.InfoS("NodeGetVolumeStats: called") |
There was a problem hiding this comment.
Are we getting rid of the args and req?
There was a problem hiding this comment.
(will add in a future pr with the updated build process)
| } | ||
|
|
||
| // IsBlock checks if the given path is a block device | ||
| func (d *nodeService) IsBlockDevice(fullPath string) (bool, error) { |
There was a problem hiding this comment.
nit: same util method here - https://github.com/aws/amazon-ecs-agent/blob/master/ecs-agent/daemonimages/csidriver/util/utils_linux.go#L22
There was a problem hiding this comment.
(will add in a future pr with the updated build process)
mye956
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds NodeStage to the internal/minimal EBS CSI Driver. This code comes directly from https://github.com/kubernetes-sigs/aws-ebs-csi-driver and is used to create a minimal Node-specific driver.
Implementation details
The driver is updated to use the public.ecr.aws/eks-distro-build-tooling/eks-distro-minimal-base-csi-ebs base image which contains all requisite mount utilities in the path while still keeping the overall driver to ~50mb in size. The NodeStage implementation adds only the files and dependencies which are directly tied to the EBS volume Mount/format/fs resize.
Testing
Manual test process:
New tests cover the changes: no
Description for the changelog
Update Minimal CSI Driver with NodeStage method.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.