Add AgentConfigAccessor interface to ecs-agent/ #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythri-garaga
previously approved these changes
Sep 26, 2023
danehlim
force-pushed
the
agent-config-accessor
branch
from
9a04051
to
0e09573
Compare
prateekchaudhry
approved these changes
Sep 26, 2023
mythri-garaga
approved these changes
Sep 26, 2023
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
AgentConfigAccessorinterface to ecs-agent module. This interface abstraction allows for access to an agent config via a set of designated methods and will be used in upcoming future pull requests.For clarity, this pull request just adds files to the ecs-agent module and does NOT change the agent module in any way to use these files.
Implementation details
AgentConfigAccessorinterface toecs-agent/config/interface.goecs-agent/config/generate_mocks.goAgentConfigAccessorinterfaceTesting
Unit, integration, and functional tests.
New tests cover the changes: N/A
Description for the changelog
Add AgentConfigAccessor interface to ecs-agent/
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.