Minor refactor of TTL cache (allow nil TTL + get TTL) #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
changed the title
Realmonia
approved these changes
Oct 17, 2023
SreeeS
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, TTL cache MUST have a TTL value specified that is limited to the following range:
[-9223372036854775808, 9223372036854775807]. This pull request allows for the TTL cache to have nil TTL set (i.e. practically equivalent to ∞ TTL).Also, this pull request adds a
GetTTLmethod for TTL cache. This method is currently mainly used in testing and compliments theSetTTLmethod that was added as part of #3953.Implementation details
TTLand use in favor of current typetime.Duration(which has underlying typeint64)GetTTLmethod for TTL cacheTesting
Unit, integration, and functional tests.
New tests cover the changes: existing tests updated
Description for the changelog
Minor refactor of TTL cache (allow nil TTL + get TTL)
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.