Add a mock for VolumeDriver interface #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
force-pushed
the
refactor-volume-plugin
branch
from
fecbb8c
to
629675e
Compare
sparrc
approved these changes
Dec 14, 2023
prateekchaudhry
approved these changes
Dec 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves
VolumeDriverinterface and related types of ECS Volume Plugin to a new package and adds a mock implementation of the driver to help with unit testing for upcoming PRs.Implementation details
VolumeDriverinterface fromvolumespackage tovolumes/driverpackage.VolumeDriver.Testing
Existing unit tests pass.
New tests cover the changes: NA
Description for the changelog
Add a mock for VolumeDriver interface
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.