Bug: fsx windows fileserver SSM arn parsing was incorrect #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-annamalai
force-pushed
the
dev
branch
2 times, most recently
from
7bb16a1
to
1b5f2f0
Compare
yinyic
reviewed
Dec 14, 2023
agent/taskresource/fsxwindowsfileserver/fsxwindowsfileserver_windows_test.go
Outdated
Show resolved
Hide resolved
yinyic
previously approved these changes
Dec 14, 2023
|
Will be posting integ test results here when completed. |
amogh09
reviewed
Dec 15, 2023
agent/taskresource/fsxwindowsfileserver/fsxwindowsfileserver_windows.go
Outdated
Show resolved
Hide resolved
|
Integ test results: successfully reproduced the issue wherein task with FSx using SSM parameter for credentials fails with |
amogh09
previously approved these changes
Dec 15, 2023
arun-annamalai
force-pushed
the
dev
branch
2 times, most recently
from
95be4a7
to
3c5a674
Compare
amogh09
reviewed
Dec 20, 2023
amogh09
approved these changes
Dec 20, 2023
arun-annamalai
force-pushed
the
dev
branch
2 times, most recently
from
ad0fb37
to
deea310
Compare
yinyic
approved these changes
Dec 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the parsing of the ssm parameter name in the fsx windows file server workflow is incorrect. This is causing customers incorrect behavior when using ssm parameters that have a folder hierarchy.
Summary
This PR is to fix the above bug and allow customers to use ssm parameters that have a folder hierarchy.
Implementation details
Testing
Unit Tests
New tests cover the changes: yes
Description for the changelog
Bug: fsx windows fileserver SSM arn parsing was incorrect
Does this PR include breaking model changes? If so, Have you added transformation functions?
No model changes
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.