Add extra logs in netlib package #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional logs to increase visibility into network builder executions has been added.
xxx0624
approved these changes
Feb 16, 2024
timj-hh
reviewed
Feb 16, 2024
| @@ -182,6 +183,12 @@ func (c *common) buildAWSVPCNetworkNamespaces( | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| logger.Info("Building network configuration for awsvpc task", map[string]interface{}{ | |||
There was a problem hiding this comment.
nit: prefer logger.Fields to a map literal, and we will usually add commonly used fields like the one you are introducing to the constants file [link]
Same comment for all of these logs
timj-hh
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional logs to increase visibility into network builder executions has been added.
Implementation details
Added logs in
netlib/platform/common_linux.gofile.Testing
go test -tags unit ./netlib/...
New tests cover the changes:
N/A
Description for the changelog
Additional logs to increase visibility into network builder executions has been added.
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.