Config: Do not compute endpoint; make region fatal #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK can handle setting the endpoint better than the Config code did; the endpoint behavior before was a legacy of a time with no sdk. The specific issue was that the endpoint would be set incorrectly if the ec2 metadata service did not return any value. In line with this, if no region can be determined it now is a fatal error. Relates to aws#74
| if *versionFlag { | ||
| versionableEngine := engine.NewTaskEngine(cfg) | ||
| version.PrintVersion(versionableEngine) | ||
| return exitcodes.ExitSuccess | ||
| } | ||
|
|
||
| if err != nil { | ||
| log.Criticalf("Error loading config: %v", err) | ||
| return exitcodes.ExitTerminal |
There was a problem hiding this comment.
Do we need a distinction between retry-able config errors (can't read from metadata service because it's not up yet) versus total failures (cannot parse)? Your only fatal one right now is AWSRegion which can potentially be retry-able.
|
@samuelkarp Addressed your comments. |
|
👍 |
euank
added a commit
that referenced
this pull request
May 20, 2015
Config: Do not compute endpoint; make region fatal
danehlim
pushed a commit
to danehlim/amazon-ecs-agent
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK can handle setting the endpoint better than the Config code did;
the endpoint behavior before was a legacy from a time with no SDK.
The specific issue was that the endpoint would be set incorrectly if the
ec2 metadata service did not return any value.
In line with this, if no region can be determined it now is a fatal
error.
Possibly relates to #74, though I'm not certain.
r? @samuelkarp