Add --enable-execute-command support (requires an aws-sdk-go version bump) #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minimum aws-sdk-go is v1.38.66 for enable execute command support - Updated Gopkg.toml - 'dep ensure' boosted version to 1.40.54 despite constraint added to to Gopkg.toml - Ran 'make generate'
Added support for boolean EnableExecuteCommand flag when using `ecs-cli compose service` commands. Modeled on how support for ForceNewDeployment was added way back in the olden days. Updated github.com/aws/aws-sdk-go dependency to 1.38.66 in the process and re-generated needed mocks. Running `dep ensure` updated aws-sdk-go in Gopkg.lock to 1.40.54 despite the constraint placed in Gopkg.toml
|
Hello, are you planning to merge this at some point? thanks |
|
This feature would be extremely useful. Having to use "aws ecs update-service" is kind of troublesome since tasks are already running after compose up'ing with ecs-cli. Maybe this PR could reduce number of file changes to facilitate its review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for boolean EnableExecuteCommand flag when using
ecs-cli compose servicecommands.Modeled on how support for ForceNewDeployment was added way back in the olden days.
Addresses #1133
I wanted to use this flag to update some existing tasks and services, so I did my best to implement it, despite not being a golang expert. I included tests for the new functionality.
The required aws-sdk-go version bump led me to regenerate mocks, revendor, update Gopkg.toml, and run
dep ensure.makeandmake docker-buildrun successfuly on my dev machine.make docker-testcomes back with no failures.I used the generated binary to do some 'compose service create' and 'compose service up' actions, and it worked!
Hope this is a useful effort!
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.