Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alternative docker endpoints #14

Closed
tomwilkie opened this issue Jun 25, 2015 · 4 comments
Closed

Support alternative docker endpoints #14

tomwilkie opened this issue Jun 25, 2015 · 4 comments
Labels
kind/enhancement

Comments

@tomwilkie
Copy link

Hi there - would you be open to a PR to allow ecs-init to read the location of the docker endpoint out of the config file?
@euank
Copy link
Contributor

euank commented Jun 25, 2015

Sounds like a good idea to me, though it might make sense to use the more canonical environment variable DOCKER_HOST in addition to just a config file option.

PR welcome, thanks!

@tomwilkie tomwilkie mentioned this issue Jun 26, 2015
Closed
@tomwilkie
Copy link
Author

Agreed, environment better in this case.

@samuelkarp
Copy link
Contributor

I've just merged #17, so this is now pending release.

@samuelkarp
Copy link
Contributor

This was released a while ago with https://github.com/aws/amazon-ecs-init/releases/tag/v1.3.1-1. Closing.

samuelkarp pushed a commit to samuelkarp/amazon-ecs-init that referenced this issue Mar 13, 2018
@cbbarclay
Merge pull request aws#14 from santtu/patch-1
93edc41 
Typo fix in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomwilkie @samuelkarp @euank