Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unquoted paths could result in incorrect output #36

Closed
jahkeup opened this issue May 24, 2018 · 1 comment
Closed

Unquoted paths could result in incorrect output #36

jahkeup opened this issue May 24, 2018 · 1 comment
Labels
enhancement

Comments

@jahkeup
Copy link
Member

jahkeup commented May 24, 2018

Summary

The unquoted paths in the ecs-logs-collector.sh could result in the script breaking due to unanticipated spaces or could place files in unexpected locations.
@jahkeup jahkeup mentioned this issue May 24, 2018
Merged
4 tasks
thereadonly pushed a commit to thereadonly/ecs-logs-collector that referenced this issue Oct 12, 2018
Addressed issue aws#36 by using ShellCheck
9bb8eda 
 Committer: sdk <dinesh@thereadonly.com>
jahkeup pushed a commit to thereadonly/ecs-logs-collector that referenced this issue Nov 13, 2018
@jahkeup
Addressed issue aws#36 by using ShellCheck
f177c49 
 Committer: sdk <dinesh@thereadonly.com>
jahkeup added a commit that referenced this issue Nov 13, 2018
@jahkeup
Merge pull request #45 from thereadonly/master
25780aa 
Addressed issue #36 by using ShellCheck
@jahkeup
Copy link
Member Author

jahkeup commented Nov 13, 2018

This is handled better with the changes that came in with #45. Closing.

@jahkeup jahkeup closed this as completed Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jahkeup