add metrics for knowing adoption #122
Conversation
This reverts commit 3efdb9f.
jyotimahapatra
changed the title
There was a problem hiding this comment.
Would an equivalent metric that contains more information be a better alternative, like number of pods injected, number of service accounts with annotations seen, etc? If num_annotated_service_accounts_seen = 0 then we can assume the cluster is not using the webhook, but I'm not sure a good way to actually keep track of that. A set of service account UIDs would work but would grow unbounded. A gauge that returned the current number of annotated service accounts would work but wouldn't show clusters that had seen previous usage (not sure if we want that). Maybe you can add some context to the description, and if this is just the simplest option for the information we need, I'm ok with that.
pkg/cache/cache.go
Outdated
| } | ||
|
|
||
| // We need a way to know if the webhook is used in a cluster to drive changes. | ||
| // We could perform more interesting operations by knowing how many service accounts are being annotated. |
There was a problem hiding this comment.
I think this phrasing is a little awkward, maybe drop the "to drive changes"? Also what are you referring to regarding "more interesting operations"?
There was a problem hiding this comment.
I brainstormed a bit about this with @wongma7 . The number of pods injected is a good metrics, but that doesn't give us details about usage if the pods don't churn. We could add that as well, but we decided we don't have a usecase for the information.
The number of annotated service accounts is a good metric, but we it needs a bit of refactoring to make sure resync and update don't cause noise in the number. We chose to stick closer to what we need, know about usage in the clusters we operate.
Issue #, if available:
Description of changes:
While handling the infrastructure for a cluster, we need a way to know which clusters are using the webhook to drive changes that change default values through the infra.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.