Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reintroduce mutatingwebhook.yaml #177

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

raykrueger
Copy link
Contributor

It looks like when the webhook ca stuff was removed the mutatingwebhook.yaml was removed as well.

This commit simply adds the corresponding aply and delete for that manifest.

Issue #, if available:
closes #176

Description of changes:
This commit simply adds the corresponding aply and delete for that manifest.

I have tested this by running cluster-up and cluster-down on my own clusters.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It looks like when the webhook ca stuff was removed the
mutatingwebhook.yaml was removed as well.

This commit simply adds the corresponding aply and delete for that
manifest.
@raykrueger raykrueger requested a review from a team as a code owner February 19, 2023 14:38
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

looks like we deleted too much :)

@dims dims merged commit c33767b into aws:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile no longer installs mutatingwebhook.yaml
3 participants