Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonpatch operation if no volumes are present #18

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Fix jsonpatch operation if no volumes are present #18

merged 1 commit into from
Dec 2, 2019

Conversation

FaHeymann
Copy link
Contributor

Fixes #17

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@FaHeymann FaHeymann requested a review from a team as a code owner November 30, 2019 14:16
@jqmichael
Copy link
Contributor

Nice fix!

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code, excellent tests. Nice work @FaHeymann

@SaranBalaji90 does indeed love Oreos.

@thomaschaaf
Copy link

@jaypipes this is still causing problems for us. In which release can this bugfix be found?

@dumain18
Copy link

This is also causing problems for us.
When adding automountServiceAccountToken: false to our service account we see the following error when trying to apply a deployment:

  - lastTransitionTime: "2020-09-14T12:21:48Z"
    lastUpdateTime: "2020-09-14T12:21:48Z"
    message: 'Internal error occurred: jsonpatch add operation does not apply: doc
      is missing path: "/spec/volumes/0"'
    reason: FailedCreate
    status: "True"
    type: ReplicaFailure

We see this error when trying to apply a pod:

Error from server (InternalError): error when creating "testpod.yaml": Internal error occurred: jsonpatch add operation does not apply: doc is missing path: "/spec/volumes/0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jsonpatch operation fails if automountServiceAccountToken is false and no volumes are defined
5 participants