Adjust min serviceaccounttoken expiration to 10min #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #155
Description of changes:
The desired expiration time for serviceaccount tokens can be set via the
eks.amazonaws.com/token-expiration
annotation on the serviceaccount.Currently, the 1hr minimum overrides token requests for shorter expiration: https://github.com/aws/amazon-eks-pod-identity-webhook/blob/master/pkg/validation.go#L17
This change aligns minimum serviceaccount token expiration to 10min to match the minimum permissible at apiserver: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L1148
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.