Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup old healthz endpoint #231

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

modulitos
Copy link
Contributor

Description of changes:
This PR removes the deprecated /healthz endpoint as part of unifying the healthcheck with the application port.

This change is a followup from an earlier PR: #229

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@modulitos modulitos requested a review from a team as a code owner July 9, 2024 02:23
@kmala kmala merged commit bd3e26d into aws:master Jul 9, 2024
1 check passed
@vbabenkoru
Copy link

vbabenkoru commented Jul 22, 2024

Was there any deprecation period for this? Looks like the health check was just moved to another port in a single release, a breaking change.
With the latest version, our health checks on the deployment stopped working because of this change and caused the pods to enter CrashLoopBackOff.
I think it'd be great to highlight this breaking change in the release notes. @kmala @modulitos

@kmala
Copy link
Contributor

kmala commented Jul 23, 2024

Was there any deprecation period for this? Looks like the health check was just moved to another port in a single release, a breaking change.

release v0.5.5 https://github.com/aws/amazon-eks-pod-identity-webhook/releases/tag/v0.5.5 has change to publish healthz on both the ports and the next release will remove healthz from the metrics port.

With the latest version, our health checks on the deployment stopped working because of this change and caused the pods to enter CrashLoopBackOff.

which version are you using because we haven't made a release yet with this change and we would be highlighting it as part of the release notes.

@modulitos
Copy link
Contributor Author

@vbabenkoru

The latest release (v0.5.6) removes the old healthcheck endpoint, and highlights this breaking change in the the release notes: https://github.com/aws/amazon-eks-pod-identity-webhook/releases/tag/v0.5.6

So the deprecation period was from v0.5.5 to v0.5.6

Thank you for bringing this up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants