Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Commit

Permalink
Fix a dependency parsing bug in CMake from #1161 (#1655)
Browse files Browse the repository at this point in the history
In previous PR when we add a feature to disable building demos and
test, we add a check to not search dependencies of aws_demos and
aws_tests target when demos or tests are disabled. But we forgot to also
move adding the dependencies to demos_base and tests_base inside the
check. As a result, the "dependencies" from previous for loop was added
to demos_base and tests_base.
  • Loading branch information
Tiangang Song committed Dec 23, 2019
1 parent fb6bf8e commit a89fca8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/cmake/afr_module.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,8 @@ function(afr_resolve_dependencies)
# If neither demos nor tests are enabled, then don't search the aws_demos/aws_tests targets.
if(AFR_ENABLE_DEMOS OR AFR_ENABLE_TESTS)
__search_afr_dependencies(${exe_target} dependencies)
afr_module_dependencies(${exe_base} INTERFACE ${dependencies})
endif()
afr_module_dependencies(${exe_base} INTERFACE ${dependencies})

# Make sure kernel can be enabled first.
__resolve_dependencies(kernel)
Expand Down

0 comments on commit a89fca8

Please sign in to comment.