This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix DHCP option Client-identifier #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is per 9.14 section of RFC at https://tools.ietf.org/html/rfc2132 and observed in the context of espressif/esp-idf#4060 |
|
Hi Shubham, thank you for this PR. I tested the changes in one of my boards and indeed it looks good, and conform the RFC. |
|
/bot run checks |
dan4thewin
approved these changes
Jan 20, 2020
tgsong
approved these changes
Jan 20, 2020
alfred2g
pushed a commit
to alfred2g/amazon-freertos
that referenced
this pull request
Jan 28, 2020
yuhui-zheng
pushed a commit
to yuhui-zheng/amazon-freertos
that referenced
this pull request
Feb 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DHCP option 61 i.e.
Client-Identifierconsist of type-value pairs. In FreeRTOS TCP stack, value is assigned, while the type is missing.Hence, type is added in Client-identifier option, which has value 0x1.
0x1corresponds toEthernet.Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.