This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Hygiene: move filename extraction logic from logging header to source file #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarg
previously approved these changes
Feb 9, 2021
aggarg
approved these changes
Feb 9, 2021
|
/bot run checks |
aggarw13
deleted the
hygiene/improve-file-name-metadata-logic-in-logging
branch
This was referenced Feb 9, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the implementation of adding filename metadata in logs (when
LOGGING_ENABLE_METADATA_WITH_C99_AND_GNU_EXTENSIONconfig is enabled) by moving string operation logic fromlogging_stack.hto.cfile that encapsulates implementation of logging functions. Also, replace use of toolchain-identifying preprocessor logic withif-elselogic that reliably extracts filename from file-path.