Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rebuffer to live #154

Merged
merged 1 commit into from
Aug 29, 2023
Merged

feat: rebuffer to live #154

merged 1 commit into from
Aug 29, 2023

Conversation

Bowlerr
Copy link
Contributor

@Bowlerr Bowlerr commented Aug 18, 2023

Issue #, if available:

Package is currently missing the setRebufferToLive property on the Android and iOS SDK.

ref: https://aws.github.io/amazon-ivs-player-docs/1.20.0/ios/Classes/IVSPlayer.html#/c:objc(cs)IVSPlayer(im)setRebufferToLive:

Description of changes:

Adds rebufferToLive prop to IVSPlayer.
Native code which links prop to setRebufferToLive

Enable skipping to the live edge on a rebuffer. Note this can cause video content and content associated with it such as timed metadata to be skipped. Defaults to false.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Bowlerr Bowlerr marked this pull request as ready for review August 19, 2023 00:09
Copy link
Contributor

@dawhitla dawhitla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dawhitla dawhitla merged commit bf136e1 into aws:main Aug 29, 2023
5 checks passed
@Bowlerr Bowlerr deleted the feat/rebuffer-to-live branch September 1, 2023 10:12
@dawhitla dawhitla mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants