add missed indentation for docker-build #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
reviewed
Aug 22, 2023
.github/workflows/pr-tests.yaml
Outdated
| @@ -48,4 +48,4 @@ docker-build: | |||
| with: | |||
| go-version: "1.20" | |||
| - name: Build Network Policy Controller images | |||
| run: make docker-buildx | |||
| run: PLATFORMS=linux/amd64 make docker-buildx | |||
There was a problem hiding this comment.
We will have to set like this - https://github.com/aws/aws-network-policy-agent/blob/main/Makefile#L182
There was a problem hiding this comment.
There was a problem hiding this comment.
We set the flag to single platform due to an upstream issue with buildx and build flag --load. We may workaround the issue with a single platform when build individual image. We may also try not to use the flag. Since this is action to test building, I keep it as our official building process which builds the image from individual platforms with --load.
The upstream issue is still open as docker/buildx#59
jayanthvn
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
We seem missing an indentation in job.
What does this PR do / Why do we need it:
Adding the missed indentation.
If an issue # is not available please add steps to reproduce and the controller logs:
Testing done on this change:
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.