fix(core): adjust log message placeholder #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
%s
instead of$s
for the log message placeholder when logging the response code received from Redshift.Description
This adjusts the log placeholder to avoid
TypeError
being raised when constructing the log message.Motivation and Context
This change allows us to inspect the response code returned from Redshift. I was seeing "Server refuses SSL" messages from the driver, and after increasing the log level to
DEBUG
thought I would see what the code actually was, but then saw this in the logs instead:This updates the log message placeholder, so it is consistent with other messages in
core.py
.Testing
As the code resides in
core.py
which has quite a low test coverage, I instead set up the following file to verify my changes:Output:
Screenshots (if appropriate)
Types of changes
Checklist
./build.sh
succeedspytest test/unit
and they are passing.