Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet readonly port disabled but still referenced in aws-cni-support.sh #285

Closed
onlybakam opened this issue Jan 10, 2019 · 1 comment
Closed

kubelet readonly port disabled but still referenced in aws-cni-support.sh #285

onlybakam opened this issue Jan 10, 2019 · 1 comment
Labels
bug good first issue

Comments

@onlybakam
Copy link

ref:

the kubelet readonly port is disabled, but the aws-cni-support.sh script still tries to access it:
curl http://localhost:10255/pods > ${LOG_DIR}/kubelet.output

the command fails and breaks the script. The line should be removed
@nak3 nak3 mentioned this issue Jan 12, 2019
Closed
@max-rocket-internet
Copy link
Contributor

Just make a PR to change the script? https://github.com/aws/amazon-vpc-cni-k8s/blob/master/scripts/aws-cni-support.sh

@liwenwu-amazon liwenwu-amazon mentioned this issue Jan 15, 2019
Closed
@mogren mogren mentioned this issue Jan 16, 2019
Closed
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Feb 11, 2019
Clean up aws-cni-support.sh and update the documentation.
ddbb065 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Feb 11, 2019
Clean up aws-cni-support.sh and update the documentation.
018864d 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
@mogren mogren mentioned this issue Feb 11, 2019
Merged
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Feb 11, 2019
Clean up aws-cni-support.sh and update the documentation.
afc8454 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Feb 12, 2019
Clean up aws-cni-support.sh and update the documentation.
0fd407a 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
@ankon ankon mentioned this issue Feb 18, 2019
Closed
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Feb 28, 2019
Clean up aws-cni-support.sh and update the documentation.
a8139f8 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Feb 28, 2019
Clean up aws-cni-support.sh and update the documentation.
7420b1d 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Feb 28, 2019
Clean up aws-cni-support.sh and update the documentation.
dae464e 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Mar 1, 2019
Clean up aws-cni-support.sh and update the documentation.
94b9b0f 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Mar 2, 2019
Clean up aws-cni-support.sh and update the documentation.
b022b27 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
rudoi pushed a commit to newrelic-forks/amazon-vpc-cni-k8s that referenced this issue Apr 1, 2019
Clean up aws-cni-support.sh and update the documentation.
f5e1bb4 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Apr 25, 2019
Clean up aws-cni-support.sh and update the documentation.
565c54c 
* Standardized on .out for output
* Create log directory if it doesn't exist
* Stop referencing `localhost:10255`
* Consistent parameter substitution

Fixes aws#285 and aws#311

(cherry picked from commit ddbb065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mogren @onlybakam @max-rocket-internet