Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging texts for ENI cleanup #1209

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Fix logging texts for ENI cleanup #1209

merged 2 commits into from
Sep 17, 2020

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Sep 12, 2020

What type of PR is this?
cleanup

Which issue does this PR fix:
None

What does this PR do / Why do we need it:
The log lines when we are doing ENI cleanup don't look right.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Check logs when

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:
No

Does this PR introduce any user-facing change?:
None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren requested a review from haouc September 12, 2020 00:14
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@mogren mogren force-pushed the log-eni-cleanup branch 4 times, most recently from 4d69090 to 0b64579 Compare September 12, 2020 06:04
@mogren mogren changed the title Fix logging tests for ENI cleanup Fix logging texts for ENI cleanup Sep 17, 2020
@mogren mogren merged commit 3c8e804 into aws:master Sep 17, 2020
@mogren mogren deleted the log-eni-cleanup branch September 17, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants