Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some minimal tests to metrics #1228

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Sep 24, 2020

What type of PR is this?
cleanup

Which issue does this PR fix:

  • Fix broken mocks
  • Add generate_mock.go for discovery.go
  • Initial scaffolding to add more unit tests (discovery.go needs a cleanup..)
  • Ignore main.go for test coverage, it is just for wiring together the other components.

Why do we need it:
Small steps to clean up the code base

Testing done on this change:
Just added a unit test, and make unit-test is passing

Automation added to e2e:
No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:
No

Does this PR introduce any user-facing change?:
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants