-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi card support - Prevent route override for primary ENI across multi-cards ENAs #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
force-pushed
the
multi-efa-support
branch
from
March 4, 2021 22:56
90ce6bd
to
92eb87d
Compare
achevuru
reviewed
Mar 5, 2021
achevuru
reviewed
Mar 5, 2021
achevuru
reviewed
Mar 5, 2021
fawadkhaliq
suggested changes
Mar 5, 2021
fawadkhaliq
reviewed
Mar 5, 2021
fawadkhaliq
reviewed
Mar 10, 2021
fawadkhaliq
approved these changes
Mar 13, 2021
haouc
pushed a commit
to haouc/amazon-vpc-cni-k8s
that referenced
this pull request
Apr 2, 2021
…lti-cards ENAs (aws#1396) * Multi card support * Updated filterunmanaged ENIs to account for both unmanaged and CNI unmanaged * Missed commiting this * Fixed infinite retries * Debug logs for CIDR not null scenarios * pr review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
Which issue does this PR fix:
No
What does this PR do / Why do we need it:
ENAs can be on multi-card (P4 family) and CNI currently doesn't support non-zero network card index. So on nodeInit, CNI thinks all the attached ENIs are on card 0, hence this PR will make CNI aware of that. But CNI doesnt allocate pods or secondary IPs on non-zero network cards. Support will be in future releases.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
NodeInit
Reconciler -
RefreshSGIDs -
Automation added to e2e:
Yes
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.