Unblocks Github Action Integration Tests #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
couralex6
force-pushed
the
test-mod
branch
9 times, most recently
from
fb1c50d
to
99125bc
Compare
couralex6
changed the title
fawadkhaliq
approved these changes
Apr 29, 2021
This was referenced Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
None
What does this PR do / Why do we need it:
There were multiple issues with the integration tests that this PR address:
1. Missing dependency: Integration tests in Github Actions started failing because of a dependency that ceased to exist:
github.com/mholt/caddy@v0.0.0-20180213163048-2de495001514.This was fixed by adding the following line to go.mod:
replace github.com/mholt/caddy => github.com/caddyserver/caddy v1.0.32. aws-k8s-tester issue: aws-k8s-tester was returning an error code 1 after attempting to output logs in color.
3. Running Upstream K8s conformance test suite twice: scripts/run-integration-tests.sh L274-L280 We were first downloading ginkgo as a binary and executing it, which returned the error:
This was solved by only executing the previously downloaded e2e tests:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
These changes were tested by manually executing the pipeline: job link
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.