Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warm ENI/IP target integration tests #1438

Merged
merged 1 commit into from
Apr 29, 2021
Merged

add warm ENI/IP target integration tests #1438

merged 1 commit into from
Apr 29, 2021

Conversation

abhipth
Copy link
Contributor

@abhipth abhipth commented Apr 23, 2021

What type of PR is this?
Integration Tests

Which issue does this PR fix:
NA

What does this PR do / Why do we need it:
Integration test for the configurable warm target variables given below

  • WARM_ENI_TARGET
  • WARM_IP_TARGET
  • MAX_ENI
  • MINIMUM_IP_TARGET

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Running Suite: VPC IPAMD Test Suite
===================================
Random Seed: 1619186249
Will run 8 of 8 specs

STEP: creating test namespace
test warm target variables when warm ENI target is used when WARM_ENI_TARGET = 2 and MAX_ENI = 1 
  instance should have only 1 ENI
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:67
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MAX_ENI:1 WARM_ENI_TARGET:2]
STEP: updating the daemon set with new environment variable
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MAX_ENI:{} WARM_ENI_TARGET:{}]
STEP: updating the daemon set with new environment variable

• [SLOW TEST:210.788 seconds]
test warm target variables
/Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:30
  when warm ENI target is used
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:32
    when WARM_ENI_TARGET = 2 and MAX_ENI = 1
    /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:61
      instance should have only 1 ENI
      /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:67
------------------------------
test warm target variables when warm ENI target is used when WARM_ENI_TARGET = 3 
  instance should have only 3 ENIs
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:76
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MAX_ENI:0 WARM_ENI_TARGET:3]
STEP: updating the daemon set with new environment variable
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MAX_ENI:{} WARM_ENI_TARGET:{}]
STEP: updating the daemon set with new environment variable

• [SLOW TEST:196.425 seconds]
test warm target variables
/Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:30
  when warm ENI target is used
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:32
    when WARM_ENI_TARGET = 3
    /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:70
      instance should have only 3 ENIs
      /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:76
------------------------------
test warm target variables when warm ENI target is used when WARM_ENI_TARGET = 1 
  instance should have only 1 ENI
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:85
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MAX_ENI:0 WARM_ENI_TARGET:1]
STEP: updating the daemon set with new environment variable
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MAX_ENI:{} WARM_ENI_TARGET:{}]
STEP: updating the daemon set with new environment variable

• [SLOW TEST:202.557 seconds]
test warm target variables
/Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:30
  when warm ENI target is used
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:32
    when WARM_ENI_TARGET = 1
    /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:79
      instance should have only 1 ENI
      /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:85
------------------------------
test warm target variables when warm IP target is set when WARM_IP_TARGET = 2 
  should have 2 secondary IPv4 addresses
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:134
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:0 WARM_IP_TARGET:2]
STEP: updating the daemon set with new environment variable
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:{} WARM_IP_TARGET:{}]
STEP: updating the daemon set with new environment variable

• [SLOW TEST:120.427 seconds]
test warm target variables
/Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:30
  when warm IP target is set
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:90
    when WARM_IP_TARGET = 2
    /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:128
      should have 2 secondary IPv4 addresses
      /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:134
------------------------------
test warm target variables when warm IP target is set when WARM_IP_TARGET = 16 
  should have 16 secondary IPv4 addresses
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:143
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:0 WARM_IP_TARGET:16]
STEP: updating the daemon set with new environment variable
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:{} WARM_IP_TARGET:{}]
STEP: updating the daemon set with new environment variable

• [SLOW TEST:98.435 seconds]
test warm target variables
/Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:30
  when warm IP target is set
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:90
    when WARM_IP_TARGET = 16
    /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:137
      should have 16 secondary IPv4 addresses
      /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:143
------------------------------
test warm target variables when warm IP target is set when MINIMUM_IP_TARGET = 2 
  should have 2 secondary IPv4 addresses
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:152
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:2 WARM_IP_TARGET:0]
STEP: updating the daemon set with new environment variable
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:{} WARM_IP_TARGET:{}]
STEP: updating the daemon set with new environment variable

• [SLOW TEST:114.891 seconds]
test warm target variables
/Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:30
  when warm IP target is set
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:90
    when MINIMUM_IP_TARGET = 2
    /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:146
      should have 2 secondary IPv4 addresses
      /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:152
------------------------------
test warm target variables when warm IP target is set when MINIMUM_IP_TARGET = 16 
  should have 16 secondary IPv4 addresses
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:161
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:16 WARM_IP_TARGET:0]
STEP: updating the daemon set with new environment variable
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:{} WARM_IP_TARGET:{}]
STEP: updating the daemon set with new environment variable

• [SLOW TEST:132.466 seconds]
test warm target variables
/Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:30
  when warm IP target is set
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:90
    when MINIMUM_IP_TARGET = 16
    /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:155
      should have 16 secondary IPv4 addresses
      /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:161
------------------------------
test warm target variables when warm IP target is set when MINIMUM_IP_TARGET = 6 and WARM_IP_TARGET = 10 
  should have 10 secondary IPv4 addresses
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:170
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:10 WARM_IP_TARGET:6]
STEP: updating the daemon set with new environment variable
STEP: getting the aws-node daemon set in namesapce kube-system
STEP: setting the environment variables on the ds to map[MINIMUM_IP_TARGET:{} WARM_IP_TARGET:{}]
STEP: updating the daemon set with new environment variable

• [SLOW TEST:123.431 seconds]
test warm target variables
/Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:30
  when warm IP target is set
  /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:90
    when MINIMUM_IP_TARGET = 6 and WARM_IP_TARGET = 10
    /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:164
      should have 10 secondary IPv4 addresses
      /Users/abhipth/go/src/github.com/aws/amazon-vpc-cni-k8s/test/integration-new/ipamd/warm_target_test.go:170
------------------------------
STEP: deleting test namespace

Ran 8 of 8 Specs in 1211.873 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 20m20.331040923s
Test Suite Passed

Automation added to e2e:
NA

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
NA

Does this change require updates to the CNI daemonset config files to work?:
NA

Does this PR introduce any user-facing change?:
NA

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@abhipth
add warm target integration tests
bb87108 
Tests
- WARM_ENI_TARGET
- WARM_IP_TARGET
- MAX_ENI
- MINIMUM_IP_TARGET
fawadkhaliq
fawadkhaliq approved these changes Apr 27, 2021
View reviewed changes
Copy link

@fawadkhaliq fawadkhaliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fawadkhaliq
Copy link

Are these tests running in the "Integration tests" workflow?

jayanthvn
jayanthvn approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fawadkhaliq fawadkhaliq merged commit fa004a1 into aws:master Apr 29, 2021
@abhipth abhipth deleted the warm-targets branch May 5, 2021 05:55
This was referenced Jun 10, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayanthvn jayanthvn jayanthvn approved these changes

@fawadkhaliq fawadkhaliq fawadkhaliq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abhipth @fawadkhaliq @jayanthvn