VPC CNI Integration Test Fixes #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
changed the title
sushrk
reviewed
Oct 17, 2022
sushrk
reviewed
Oct 17, 2022
jdn5126
changed the title
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This PR fixes three issues in VPC CNI integration tests.
Calico tests are removed from
run-cni-release-tests.sh. Calico integration tests are already covered by the GitHub runner that invokesrun-integration-tests.sh, and this provides the appropriate level of CNI regression testing. Calico tests would need to be refactored to run against Windows nodes in order to return torun-cni-release-tests.sh. The GitHub runner invokes them against Linux nodes.CNI host networking tests are refactored to increase the
WARM_IP_TARGET. This value was increased so that the test better mirrored a real customer setup. The value could only be changed for host networking tests as other CNI integration tests depend on the value set in the suite setup. The flakiness of this test led to Sandbox pause container not deleted kubernetes/kubernetes#113073 being filed.Ginkgo was upgraded to v2.3.1. This is necessary to resolve issues caused by running a ginkgo CLI client >= 2.3.0 against this repo (there is an incompatibility between versions < 2.3.0 and >= 2.3.0). The ginkgo issue is described in ginkgo v2.3.0 is failing all CI builds (and local ones as well) onsi/ginkgo#1050
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Validated that
run-cni-release-tests.shpasses.Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.