Add bmn-sf1.metal instance support #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
reviewed
Feb 27, 2023
Discussed offline, approved |
jdn5126
approved these changes
Feb 27, 2023
|
@vpineda1996 can you also link the PR for https://github.com/awslabs/amazon-eks-ami ? |
|
Synced up with @vpineda1996, currently they don't want EKS AMI support for the first build since customer will be using RHEL. Since this is added as manual limits there won't be any accidental deletes next time during new instance onboarding. We need to remove this check once the instance is available via describe calls.. |
|
FYI, EKS AMI support will be automatically added by a bot that runs every 24hrs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
Which issue does this PR fix:
n/a
What does this PR do / Why do we need it:
This PR adds VPC CNI support for bmn-sf1.metal instances. The instance is only allow-listed on a per-user basis on EC2.
Testing done on this change:
go scripts/gen_vpc_ip_limits.goWill this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes, user will be able to use VPC CNI with bmn-sf1.metal instances
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.