Refactor egress-v4-cni plugin to support unit testing #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
reviewed
Apr 19, 2023
There was a problem hiding this comment.
Refactor overall looks great, just some nits to help with structure. Main points are:
- Let's pull integration tests out and save that for a future PR
- Let's rename the
sharefolder
Also, can you rebase this against HEAD of master branch and squash the commits down to 1? That will make it easier to review
jdn5126
reviewed
Apr 20, 2023
There was a problem hiding this comment.
One last nit, then this is good to go, thanks @wanyufe ! Also, can you squash this into one commit? That will make the history easier to read. After that, I can kick off manual integration test job and approve once it passes
wanyufe
force-pushed
the
egress-part-1
branch
2 times, most recently
from
92113ee
to
66ab916
Compare
jdn5126
previously approved these changes
Apr 21, 2023
jdn5126
reviewed
Apr 24, 2023
achevuru
reviewed
Apr 24, 2023
achevuru
reviewed
Apr 25, 2023
jdn5126
approved these changes
Apr 25, 2023
achevuru
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Refactor, no functions changes.
Which issue does this PR fix:
egress-cni plugin has no unit-testing code.
What does this PR do / Why do we need it:
Two reasons:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Manual testing, unit testing, and integration testing
Automation added to e2e:
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.